Skip to content

fix #79 fix explain string and add support for params #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2020

Conversation

gkorland
Copy link
Contributor

@gkorland gkorland commented Jul 5, 2020

No description provided.

@gkorland gkorland requested a review from DvirDukhan July 5, 2020 09:45
@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   84.24%   84.24%           
=======================================
  Files           8        8           
  Lines         565      565           
=======================================
  Hits          476      476           
  Misses         89       89           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94995cf...fa07ca9. Read the comment docs.

@gkorland gkorland requested a review from swilly22 July 5, 2020 09:56
@lgtm-com
Copy link

lgtm-com bot commented Jul 5, 2020

This pull request fixes 2 alerts when merging fa07ca9 into 94995cf - view on LGTM.com

fixed alerts:

  • 2 for Unused local variable

@gkorland gkorland merged commit 387e86d into master Jul 6, 2020
@gkorland gkorland deleted the explain_params branch July 6, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants